Conversation
* Updated `pom.xml` & `site.xml` to change sentrysoftware occurrences by metricshub. * Upgraded some dependencies versions. * Updated `site.xml` to update the logo and upgrade the `sentry-maven-skin` version. * Updated chestyle.xml. * Tested that everything is working fine.
NassimBtk
requested changes
Mar 31, 2025
Collaborator
NassimBtk
left a comment
NassimBtk
left a comment
There was a problem hiding this comment.
- Add
src/site/resources/favicon.ico. - We need to resolve Checkstyle issues.
- Line endings in
.javafiles have changed (e.g., from LF to CRLF or vice versa). We need to fix that.
* Reformatted all the classes using prettier. * Added Favicon.ico, css and fonts inside resources directory.
* Removed some useless code to reduce the number of spotbugs reports. * Tested the build and the client.
NassimBtk
requested changes
Apr 1, 2025
* Fixed a wrong package name in pom.xml * Tested the update.
- Changed Bertrand Martin's email - Updated Nassim BOUTEKEDJIRET's email - Modified `pom.xml` file - Ensured consistency in developer contact info - Maintainer roles remain unchanged - No other changes made
- Change organization URL to metricshub.com - Update project URL to wbem-java - Ensure consistency in URL format - Reflect new URL structure in project metadata - Maintain project inception year as 2023 - No changes to other project metadata
NassimBtk
approved these changes
Apr 1, 2025
NassimBtk
deleted the
feature/issue-35-rebrand-codebase-from-sentry-software-to-metricshub
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.xml&site.xmlto change sentrysoftware occurrences by metricshub.site.xmlto update the logo and upgrade thesentry-maven-skinversion.Tests
Documentation
Non Reg test
Expected result
Actual result